mgmt: mcumgr: grp: settings_mgmt: Part revert settings save change #98336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
force-pushed
the
partialsettingsrevert
branch
from
39ab9e4 to
d3f397a
Compare
Partially reverts commit 7d2fb6c, it was originally thought that this commit added a method of saving one specific key using the value that the device already has set, but has been found to actually save the value that the user has provided, bypassing the current value that the device has, which is not compliant with the settings mgmt protocol, therefore remove this change and it will need to be reworked in future to function properly by saving one specific value from the device's current configuration, not a user-specified value Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
partialsettingsrevert
branch
from
d3f397a to
7ec7c26
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
de-nordic
approved these changes
Oct 28, 2025
jhedberg
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts commit 7d2fb6c, it was originally thought that this commit added a method of saving one specific key using the value that the device already has set, but has been found to actually save the value that the user has provided, bypassing the current value that the device has, which is not compliant with the settings mgmt protocol, therefore remove this change and it will need to be reworked in future to function properly by saving one specific value from the device's current configuration, not a user-specified value